Fix issue 20476: creating multiple LocalVariables with same name (finally_ret_val35), confuses the …

Fix issue 20476: creating multiple LocalVariables with same name (finally_ret_val35), confuses the compiler. token_pos is not enough to guarantee unique name for inlined finally-s. Instead of uniques names per inlined return node, use one function level local.

R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39206

[Florian Schneider, 2014-08-13 10:35:22]

lgtm

https://codereview.chromium.org/467933002/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/467933002/diff/40001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:7304: return_node->set_saved_return_value_var(
No need to save the variable with the ReturnNode, since there is only one per
function. You can get rid of ReturnNode::saved_return_value_var and just use
parsed_function()->finally_return_temp_var() instead.

[srdjan, 2014-08-13 15:38:55]

https://codereview.chromium.org/467933002/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/467933002/diff/40001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:7304: return_node->set_saved_return_value_var(
On 2014/08/13 10:35:22, Florian Schneider wrote:
> No need to save the variable with the ReturnNode, since there is only one per
> function. You can get rid of ReturnNode::saved_return_value_var and just use
> parsed_function()->finally_return_temp_var() instead.

Done.

[srdjan, 2014-08-13 17:03:54]

Committed patchset #5 manually as r39206 (presubmit successful).