Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 46793004: Fix unordered equality to not trigger dart2js typing restriction. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix unordered equality to not trigger dart2js typing restriction. BUG= http://dartbug.com/14654 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=29726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M pkg/collection_helpers/lib/equality.dart View 5 chunks +21 lines, -22 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 15:18:42 UTC) #1
Johnni Winther
LGTM Thanks!
7 years, 1 month ago (2013-10-31 17:43:16 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-11-01 08:09:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29726 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698