Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 467643002: Browser testing: Run android content shell tests on hosts with multiple devices connected. (Closed)

Created:
6 years, 4 months ago by Bill Hesse
Modified:
6 years, 4 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Browser testing: Run android content shell tests on hosts with multiple devices connected. The adb_reverse_forwarder.py script in [dartium]/build/android/ needs the --all-devices option added. We will also try to upstream this flag to chromium. This change makes the test host reinstall the ContentShell apk on the device each time the device is restarted due to timeout or periodic reset, which takes about 10 seconds, but this is simpler and more like the existing behavior with android chrome. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=39142

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -90 lines) Patch
M tools/bots/run_android_tests.sh View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 1 2 6 chunks +98 lines, -83 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Requires the --all-devices flag to be added to [dartium]/build/android/adb_reverse_forwarder.py in another CL. https://codereview.chromium.org/467643002/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart ...
6 years, 4 months ago (2014-08-12 13:20:12 UTC) #1
ricow1
lgtm https://codereview.chromium.org/467643002/diff/20001/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/467643002/diff/20001/tools/testing/dart/browser_controller.dart#newcode1267 tools/testing/dart/browser_controller.dart:1267: var test_driver_port = globalConfiguration['test_driver_port']; I think it sucks ...
6 years, 4 months ago (2014-08-12 13:29:23 UTC) #2
Bill Hesse
6 years, 4 months ago (2014-08-12 14:40:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r39142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698