Issue 467233003: refactor and cleanup code completion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467233003: refactor and cleanup code completion (Closed)

Created:
6 years, 4 months ago by danrubel

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

refactor and cleanup code completion - combine all elements of request into request object - pass request object through to all computers / visitors - add override annotations on visitor subclasses - rename completion_computer -> completion_manager - move DartCompletionComputer into library with other related classes BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39333

Patch Set 1 #

Patch Set 2 : revert pubspec.yaml mods #

Patch Set 3 : merge #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+377 lines, -414 lines)			Patch
M	pkg/analysis_server/lib/src/domain_completion.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	pkg/analysis_services/lib/completion/completion_computer.dart	View	1 chunk	+0 lines, -133 lines	0 comments	Download
A +	pkg/analysis_services/lib/completion/completion_manager.dart	View	3 chunks	+5 lines, -34 lines	0 comments	Download
M	pkg/analysis_services/lib/src/completion/dart_completion_manager.dart	View	6 chunks	+90 lines, -21 lines	0 comments	Download
M	pkg/analysis_services/lib/src/completion/imported_type_computer.dart	View	12 chunks	+29 lines, -27 lines	0 comments	Download
M	pkg/analysis_services/lib/src/completion/invocation_computer.dart	View	9 chunks	+25 lines, -19 lines	0 comments	Download
M	pkg/analysis_services/lib/src/completion/keyword_computer.dart	View	5 chunks	+17 lines, -14 lines	0 comments	Download
M	pkg/analysis_services/lib/src/completion/local_computer.dart	View	3 chunks	+66 lines, -58 lines	0 comments	Download
M	pkg/analysis_services/test/completion/completion_computer_test.dart	View	9 chunks	+34 lines, -64 lines	0 comments	Download
A	pkg/analysis_services/test/completion/completion_manager_test.dart	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	pkg/analysis_services/test/completion/completion_test_util.dart	View	6 chunks	+53 lines, -33 lines	0 comments	Download
M	pkg/analysis_services/test/completion/imported_type_computer_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_services/test/completion/local_computer_test.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analysis_services/test/completion/test_all.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danrubel

6 years, 4 months ago (2014-08-18 15:43:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as 39333 (presubmit successful).

Expand Messages | Collapse Messages