Issue 467183004: Add more types to service/protocol.md

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467183004: Add more types to service/protocol.md (Closed)

Created:
6 years, 3 months ago by turnidge

Modified:
6 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add more types to service/protocol.md R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39603

Patch Set 4 : alphabetize #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -146 lines)			Patch
	M	runtime/vm/service/protocol.md	View	1 2 3	8 chunks	+252 lines, -146 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

turnidge

turnidge@google.com changed reviewers: + johnmccutchan@google.com

6 years, 3 months ago (2014-08-26 20:12:00 UTC) #1

Cutch

lgtm with two comments. https://codereview.chromium.org/467183004/diff/40001/runtime/vm/service/protocol.md File runtime/vm/service/protocol.md (right): https://codereview.chromium.org/467183004/diff/40001/runtime/vm/service/protocol.md#newcode121 runtime/vm/service/protocol.md:121: | eventType | String | ...

6 years, 3 months ago (2014-08-26 20:38:43 UTC) #3

turnidge

6 years, 3 months ago (2014-08-27 16:32:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 39603 (presubmit successful).

Expand Messages | Collapse Messages

Issue 467183004: Add more types to service/protocol.md (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : alphabetize #

Messages