Issue 466813002: Support non-ASCII script URLs in VM service by using IRIs (generalized URIs).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466813002: Support non-ASCII script URLs in VM service by using IRIs (generalized URIs). (Closed)

Created:
6 years, 4 months ago by koda

Modified:
6 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support non-ASCII script URLs in VM service by using IRIs (generalized URIs). IRIs (RFC 3987) first UTF-8-encode the string and then percent-encode each byte. Thus, this change has no effect for ASCII strings. BUG=dart:20472 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39145

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -40 lines)			Patch
M	runtime/vm/object.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	6 chunks	+31 lines, -31 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	3 chunks	+19 lines, -4 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 4 months ago (2014-08-12 16:33:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r39145 (presubmit successful).

Expand Messages | Collapse Messages