Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 46673003: Remove uses of Options from utils directory. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Remove uses of Options from utils directory. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M utils/apidoc/apidoc.dart View 1 chunk +1 line, -3 lines 0 comments Download
M utils/css/tool.dart View 1 chunk +1 line, -2 lines 0 comments Download
M utils/template/tool.dart View 1 chunk +1 line, -3 lines 0 comments Download
M utils/testrunner/http_server_runner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/testrunner/options.dart View 2 chunks +1 line, -2 lines 0 comments Download
M utils/testrunner/testrunner.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M utils/testrunner/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/benchmark_runner.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M utils/tests/string_encoding/utf8_benchmarks.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/tests/testrunner/testrunner_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-10-30 15:43:58 UTC) #1
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-30 15:47:35 UTC) #2
Bill Hesse
7 years, 1 month ago (2013-10-30 15:59:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698