Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 46663003: Fix sdk/lib/io errors found by the analyzer. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix sdk/lib/io errors found by the analyzer. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29450

Patch Set 1 #

Patch Set 2 : More fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M sdk/lib/io/http_impl.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/io/string_transformer.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-10-29 13:43:50 UTC) #1
Anders Johnsen
Adding lrn as well, as these are mostly async issues.
7 years, 1 month ago (2013-10-29 13:44:24 UTC) #2
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-29 14:27:46 UTC) #3
Anders Johnsen
PTAL, found more stuff :)
7 years, 1 month ago (2013-10-29 14:29:30 UTC) #4
Søren Gjesse
LGTM!
7 years, 1 month ago (2013-10-29 14:30:22 UTC) #5
Anders Johnsen
Committed patchset #2 manually as r29450 (presubmit successful).
7 years, 1 month ago (2013-10-29 14:30:44 UTC) #6
kustermann
7 years, 1 month ago (2013-10-29 14:47:16 UTC) #7
Message was sent while issue was closed.
Thank you very much :)

Powered by Google App Engine
This is Rietveld 408576698