Issue 466013002: Add regression test for issue 20476

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466013002: Add regression test for issue 20476 (Closed)

Created:
6 years, 4 months ago by Michael Lippautz (Google)

Modified:
6 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add regression test for issue 20476 BUG=http://dartbug.com/20476 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39150

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -8 lines)			Patch
	A +	tests/language/issue20476_test.dart	View		1 chunk	+14 lines, -8 lines	0 comments	Download
	M	tests/language/language.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/466013002/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/466013002/diff/1/tests/language/language.status#newcode86 tests/language/language.status:86: [ $compiler == none && $runtime == ...

6 years, 4 months ago (2014-08-12 16:53:30 UTC) #2

Michael Lippautz (Google)

On 2014/08/12 16:53:30, Ivan Posva wrote: > LGTM -ip > > https://codereview.chromium.org/466013002/diff/1/tests/language/language.status > File tests/language/language.status ...

6 years, 4 months ago (2014-08-12 17:09:13 UTC) #3

Michael Lippautz (Google)

6 years, 4 months ago (2014-08-12 17:15:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 39150 (presubmit successful).

Expand Messages | Collapse Messages

Issue 466013002: Add regression test for issue 20476 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages