Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 46593003: Add @proxy to annotations.dart - remove package:meta. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, bakster
Visibility:
Public.

Description

Add @proxy to annotations.dart. Remove package:meta R=bak@google.com, brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=29525

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge to master. Fix typo. More text. #

Patch Set 3 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -157 lines) Patch
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 1 2 9 chunks +3 lines, -23 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonHintCodeTest.java View 7 chunks +3 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/theme/preferences/DartSample.dart View 2 chunks +1 line, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/SemanticHighlightingTest.java View 3 chunks +0 lines, -16 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 10 chunks +1 line, -36 lines 0 comments Download
M pkg/custom_element/lib/custom_element.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/intl/lib/intl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/logging/lib/logging.dart View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/meta/lib/meta.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D pkg/meta/pubspec.yaml View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/polymer/lib/component_build.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/lib/polymer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/annotations.dart View 1 4 chunks +32 lines, -8 lines 0 comments Download
M third_party/pkg/js/lib/js_wrapping.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
This removes the meta package. We might want to delay removing it completely, but only ...
7 years, 1 month ago (2013-10-29 10:32:24 UTC) #1
karlklose
DBC: https://codereview.chromium.org/46593003/diff/1/sdk/lib/core/annotations.dart File sdk/lib/core/annotations.dart (right): https://codereview.chromium.org/46593003/diff/1/sdk/lib/core/annotations.dart#newcode119 sdk/lib/core/annotations.dart:119: * class. It will not generate the warning ...
7 years, 1 month ago (2013-10-29 10:40:06 UTC) #2
bakster
lgtm
7 years, 1 month ago (2013-10-29 11:34:12 UTC) #3
Brian Wilkerson
LGTM > Is the description of proxy's meaning correct? > I.e., does it only suppress ...
7 years, 1 month ago (2013-10-29 14:09:20 UTC) #4
Lasse Reichstein Nielsen
Ok, I'll keep the limited wording for now, and update it when the spec hits. ...
7 years, 1 month ago (2013-10-30 10:15:40 UTC) #5
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-30 10:25:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r29525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698