Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 465733002: 'Rename Local Variable' refactoring implementation. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

'Rename Local Variable' refactoring implementation. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39115

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+783 lines, -127 lines) Patch
M pkg/analysis_services/lib/refactoring/refactoring.dart View 2 chunks +6 lines, -4 lines 2 comments Download
M pkg/analysis_services/lib/search/hierarchy.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/src/correction/util.dart View 5 chunks +26 lines, -2 lines 2 comments Download
M pkg/analysis_services/lib/src/refactoring/refactoring.dart View 1 chunk +14 lines, -7 lines 0 comments Download
M pkg/analysis_services/lib/src/refactoring/rename.dart View 8 chunks +85 lines, -44 lines 0 comments Download
M pkg/analysis_services/lib/src/refactoring/rename_local.dart View 2 chunks +79 lines, -7 lines 0 comments Download
A pkg/analysis_services/test/refactoring/abstract_rename.dart View 1 chunk +210 lines, -0 lines 0 comments Download
M pkg/analysis_services/test/refactoring/rename_local_test.dart View 3 chunks +349 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-11 22:21:16 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/465733002/diff/1/pkg/analysis_services/lib/refactoring/refactoring.dart File pkg/analysis_services/lib/refactoring/refactoring.dart (right): https://codereview.chromium.org/465733002/diff/1/pkg/analysis_services/lib/refactoring/refactoring.dart#newcode29 pkg/analysis_services/lib/refactoring/refactoring.dart:29: Future<RefactoringStatus> checkAllConditions(); Is it really necessary to make ...
6 years, 4 months ago (2014-08-12 04:44:40 UTC) #2
scheglov
https://codereview.chromium.org/465733002/diff/1/pkg/analysis_services/lib/refactoring/refactoring.dart File pkg/analysis_services/lib/refactoring/refactoring.dart (right): https://codereview.chromium.org/465733002/diff/1/pkg/analysis_services/lib/refactoring/refactoring.dart#newcode29 pkg/analysis_services/lib/refactoring/refactoring.dart:29: Future<RefactoringStatus> checkAllConditions(); On 2014/08/12 04:44:40, Brian Wilkerson wrote: > ...
6 years, 4 months ago (2014-08-12 05:09:34 UTC) #3
scheglov
6 years, 4 months ago (2014-08-12 05:11:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698