Adding missing dependencies for dart executable on OSX

Adding missing dependencies for dart executable on OSX

The dart build target was picking these dependencies up via nss.gyp:nspr, but when IO is not enabled then it hits a link error on some CoreFoundation APIs.


BUG=
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39113

[Ivan Posva, 2014-08-11 21:21:12]

Can you please list which dependencies from CoreFoundation were missing?

Thanks,
-Ivan

[blois, 2014-08-11 21:34:58]

On 2014/08/11 21:21:12, Ivan Posva wrote:
> Can you please list which dependencies from CoreFoundation were missing?
> 
> Thanks,
> -Ivan

From CoreServices:
Undefined symbols for architecture x86_64:
  "_FSEventStreamCreate", referenced from:
      dart::bin::FSEventsWatcher::Node::StartCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_FSEventStreamFlushSync", referenced from:
      dart::bin::FSEventsWatcher::Node::StartCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_FSEventStreamInvalidate", referenced from:
      dart::bin::FSEventsWatcher::Node::StopCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_FSEventStreamRelease", referenced from:
      dart::bin::FSEventsWatcher::Node::StopCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_FSEventStreamScheduleWithRunLoop", referenced from:
      dart::bin::FSEventsWatcher::Node::StartCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_FSEventStreamStart", referenced from:
      dart::bin::FSEventsWatcher::Node::StartCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_FSEventStreamStop", referenced from:
      dart::bin::FSEventsWatcher::Node::StopCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)

From CoreFoundation:
 "_CFAbsoluteTimeGetCurrent", referenced from:
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFArrayCreate", referenced from:
      dart::bin::FSEventsWatcher::Node::StartCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRelease", referenced from:
      dart::bin::FSEventsWatcher::Node::~Node() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Node::Stop() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Node::Start() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Node::StartCallback(__CFRunLoopTimer*, void*)
in libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Stop() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRetain", referenced from:
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRunLoopAddTimer", referenced from:
      dart::bin::FSEventsWatcher::Node::Stop() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Node::Start() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Stop() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRunLoopGetCurrent", referenced from:
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRunLoopRun", referenced from:
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRunLoopStop", referenced from:
      dart::bin::FSEventsWatcher::StopCallback(__CFRunLoopTimer*, void*) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFRunLoopTimerCreate", referenced from:
      dart::bin::FSEventsWatcher::Node::Stop() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Node::Start() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Stop() in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
      dart::bin::FSEventsWatcher::Run(unsigned long) in
libdart_io.a(libdart_io.file_system_watcher_macos.o)
  "_CFStringCreateWithCString", referenced from:
      dart::bin::FSEventsWatcher::Node::Node(dart::bin::FSEventsWatcher*, char*,
int, int, bool) in libdart_io.a(libdart_io.file_system_watcher_macos.o)

[Ivan Posva, 2014-08-11 22:06:15]

https://codereview.chromium.org/465683002/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/465683002/diff/1/runtime/bin/bin.gypi#newcode424
runtime/bin/bin.gypi:424: ['OS=="mac"', {
Thanks for the update. In that case this is the wrong place to put these,
because all other places where the FSEventsWatcher code is included will not be
linking against CoreFoundation and CoreServices.

The way I understand the dependencies the sources referring to this are being
brought in due to dart:io, so you would need to add these link settings to that
target in order to propagate to all other binaries being built such as
dart_no_snapshot and similar.

[blois, 2014-08-11 22:23:50]

Moved library dependencies over to libdart_io.

[Ivan Posva, 2014-08-11 23:21:38]

LGTM -ip

[blois, 2014-08-11 23:32:00]

Committed patchset #2 manually as 39113 (presubmit successful).