Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 46563002: Fix suggestions about using init.dart (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
vsm, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix suggestions about using init.dart R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29336

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M pkg/polymer/lib/boot.js View 1 chunk +1 line, -1 line 1 comment Download
M pkg/polymer/lib/init.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-26 01:25:56 UTC) #1
vsm
https://codereview.chromium.org/46563002/diff/1/pkg/polymer/lib/boot.js File pkg/polymer/lib/boot.js (right): https://codereview.chromium.org/46563002/diff/1/pkg/polymer/lib/boot.js#newcode8 pkg/polymer/lib/boot.js:8: + '<script type="application/dart">import "package:polymer/init.dart";' Does packages/browser/dart.js need to understand/transform ...
7 years, 1 month ago (2013-10-27 17:28:00 UTC) #2
vsm
lgtm
7 years, 1 month ago (2013-10-27 18:01:09 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-27 23:51:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698