Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 465513002: Split analysis_domain_int_test.dart into several test files. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split analysis_domain_int_test.dart into several test files. This test was timing out on the debug build bots because it had 6 sub-tests, each of which started a separate instance of the analysis server. Split it out to one test per file. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -296 lines) Patch
A + pkg/analysis_server/test/integration/analysis/error_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/get_errors.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/get_errors_after_analysis_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/get_errors_before_analysis_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 chunk +176 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/test_all.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/integration/analysis_domain_int_test.dart View 1 chunk +0 lines, -250 lines 0 comments Download
D pkg/analysis_server/test/integration/analysis_error_int_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 2 chunks +17 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-11 16:32:09 UTC) #1
scheglov
LGTM :-(
6 years, 4 months ago (2014-08-11 16:44:08 UTC) #2
Brian Wilkerson
This makes me sad too. I really think we need to work on getting the ...
6 years, 4 months ago (2014-08-11 16:51:10 UTC) #3
Paul Berry
6 years, 4 months ago (2014-08-11 17:39:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r39095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698