Issue 46513002: Comment out resolver tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46513002: Comment out resolver tests. (Closed)

Created:
7 years, 1 month ago by scheglov

Modified:
7 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Comment out resolver tests. They always should be commented, because we cannot get SDK path on bot. TBR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29304

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+24 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r29304 (presubmit successful).

7 years, 1 month ago (2013-10-26 01:00:10 UTC) #2

Brian Wilkerson

> They always should be commented, because we cannot get SDK path on bot. Then ...

7 years, 1 month ago (2013-10-26 15:19:00 UTC) #3

scheglov

7 years, 1 month ago (2013-10-26 17:24:14 UTC) #4

Message was sent while issue was closed.

On 2013/10/26 15:19:00, Brian Wilkerson wrote:
> > They always should be commented, because we cannot get SDK path on bot.
> 
> Then how do we run the equivalent Java tests?
> 
> Is there any way we can work with Rico or Martin to get access to the SDK when
> running on the bot?

I run these tests after generation of each snapshot.

I've asked Rico and Martin about access to the SDK on the bot.
There were some problems with this before, because of different layout in the
real SDK and bot.
But may be things changed since then.

Expand Messages | Collapse Messages