Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 464873004: Attempt to fix build bot by including Dart VM flags when invoking testee. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Attempt to fix build bot by including Dart VM flags when invoking testee. R=johnmccutchan@google.com TBR=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39154

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M runtime/bin/vmservice/observatory/test/test_helper.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 4 months ago (2014-08-12 18:27:01 UTC) #1
koda
6 years, 4 months ago (2014-08-12 18:27:26 UTC) #2
Cutch
lgtm
6 years, 4 months ago (2014-08-12 18:27:30 UTC) #3
koda
6 years, 4 months ago (2014-08-12 18:28:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r39154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698