Issue 464583002: Properly translate file: URIs to paths on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464583002: Properly translate file: URIs to paths on Windows. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly translate file: URIs to paths on Windows. Uri.path returns the path component of the URI in raw form. This works on MacOS and Linux, but on Windows we need for drive letters to be handled and for '/' to be converted to '\'. To do this, we have to use Uri.toFilePath(windows: ...). This was preventing the index from being able to find source files, which in turn prevented search.getTypeHierarchy from traversing subclasses (since it finds subclasses using the index). BUG=dartbug.com/20436 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39105

Patch Set 1 #

Patch Set 2 : Use fromUri to avoid depending on dart:io #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analyzer/lib/file_system/file_system.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-08-11 21:02:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r39105 (presubmit successful).

Expand Messages | Collapse Messages