'Rename Constructor' refactoring.

'Rename Constructor' refactoring.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39214

[Brian Wilkerson, 2014-08-13 18:39:19]

LGTM

https://codereview.chromium.org/464363004/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/strings.dart (right):

https://codereview.chromium.org/464363004/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/strings.dart:51: String format(String
pattern, [arg0, arg1, arg2, arg3, arg4, arg5, arg6, arg7])
(Is it really the case that there is no built-in support for this kind of
operation?)

We should have a single way of formatting strings from arguments. Let's merge
this and what we're doing in JavaString into a single pattern (and move it to
analysis engine).

[scheglov, 2014-08-13 18:53:22]

https://codereview.chromium.org/464363004/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/strings.dart (right):

https://codereview.chromium.org/464363004/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/strings.dart:51: String format(String
pattern, [arg0, arg1, arg2, arg3, arg4, arg5, arg6, arg7])
On 2014/08/13 18:39:19, Brian Wilkerson wrote:
> (Is it really the case that there is no built-in support for this kind of
> operation?)
> 
> We should have a single way of formatting strings from arguments. Let's merge
> this and what we're doing in JavaString into a single pattern (and move it to
> analysis engine).

Will do.
In the next CL.

[scheglov, 2014-08-13 18:53:51]

Committed patchset #1 manually as 39214 (presubmit successful).