Issue 463563004: Tweak for AnalysisDomainHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463563004: Tweak for AnalysisDomainHandler. (Closed)

Created:
6 years, 4 months ago by scheglov

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Tweak for AnalysisDomainHandler. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39104

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -18 lines)			Patch
	M	pkg/analysis_server/lib/src/constants.dart	View		1 chunk	+8 lines, -0 lines	2 comments	Download
	M	pkg/analysis_server/lib/src/domain_analysis.dart	View		3 chunks	+8 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/463563004/diff/1/pkg/analysis_server/lib/src/constants.dart File pkg/analysis_server/lib/src/constants.dart (right): https://codereview.chromium.org/463563004/diff/1/pkg/analysis_server/lib/src/constants.dart#newcode35 pkg/analysis_server/lib/src/constants.dart:35: const String ANALYSIS_OVERLAY_ADD = 'add'; "ANALYSIS" --> "CONTENT" ...

6 years, 4 months ago (2014-08-11 20:17:52 UTC) #2

scheglov

https://codereview.chromium.org/463563004/diff/1/pkg/analysis_server/lib/src/constants.dart File pkg/analysis_server/lib/src/constants.dart (right): https://codereview.chromium.org/463563004/diff/1/pkg/analysis_server/lib/src/constants.dart#newcode35 pkg/analysis_server/lib/src/constants.dart:35: const String ANALYSIS_OVERLAY_ADD = 'add'; On 2014/08/11 20:17:52, Brian ...

6 years, 4 months ago (2014-08-11 20:22:18 UTC) #3

scheglov

6 years, 4 months ago (2014-08-11 20:22:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 39104 (presubmit successful).

Expand Messages | Collapse Messages