Issue 463323003: Fix crash due to AbstractFieldElement.computeType.

Issue 463323003: Fix crash due to AbstractFieldElement.computeType. (Closed)

Created:
6 years, 4 months ago by ahe

Modified:
6 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, lukechurch, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix crash due to AbstractFieldElement.computeType. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39364

Patch Set 2 : Added tests/try/poi/data/abstract_field.dart #

Total comments: 3

Patch Set 3 : Merged with r39363. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -7 lines)			Patch
M	dart/site/try/poi/poi.dart	View		6 chunks	+44 lines, -2 lines	0 comments	Download
A +	dart/tests/try/poi/data/abstract_field.dart	View	1	1 chunk	+11 lines, -5 lines	0 comments	Download
M	dart/tests/try/poi/serialize_test.dart	View		2 chunks	+83 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/463323003/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/463323003/diff/20001/dart/site/try/poi/poi.dart#newcode372 dart/site/try/poi/poi.dart:372: importScope(e).importScope.values.forEach(forEach); Why this change? https://codereview.chromium.org/463323003/diff/20001/dart/site/try/poi/poi.dart#newcode387 dart/site/try/poi/poi.dart:387: localScope(e).values.forEach(forEach); Ditto.

6 years, 4 months ago (2014-08-19 06:59:30 UTC) #3

ahe

Thank you, Johnni! https://codereview.chromium.org/463323003/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/463323003/diff/20001/dart/site/try/poi/poi.dart#newcode372 dart/site/try/poi/poi.dart:372: importScope(e).importScope.values.forEach(forEach); On 2014/08/19 06:59:29, Johnni Winther ...

6 years, 4 months ago (2014-08-19 08:41:52 UTC) #4

ahe

6 years, 4 months ago (2014-08-19 09:01:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as 39364 (presubmit successful).

Expand Messages | Collapse Messages