Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 463123002: Run dart2js in batch mode also on windows (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run dart2js in batch mode also on windows R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=39192

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/bots/compiler.py View 3 chunks +1 line, -8 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
ricow1
https://codereview.chromium.org/463123002/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/463123002/diff/1/tools/bots/compiler.py#newcode26 tools/bots/compiler.py:26: r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minified))?(-(x64))?(-(batch))?-?(\d*)-?(\d*)') I will remove it from here once I ...
6 years, 4 months ago (2014-08-12 13:17:06 UTC) #1
floitsch
LGTM.
6 years, 4 months ago (2014-08-12 13:17:52 UTC) #2
ricow1
6 years, 4 months ago (2014-08-13 08:05:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39192 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698