Issue 462403004: Refactor deopt_instructions.cc to minimize boilerplate and duplication.

Issue 462403004: Refactor deopt_instructions.cc to minimize boilerplate and duplication. (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 4 months ago

Reviewers:
Florian Schneider, Cutch, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor deopt_instructions.cc to minimize boilerplate and duplication. BUG= R=fschneider@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39519

Patch Set 3 : renamings and comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+375 lines, -710 lines)			Patch
	M	runtime/vm/deopt_instructions.h	View	1 2	8 chunks	+130 lines, -30 lines	0 comments	Download
	M	runtime/vm/deopt_instructions.cc	View	1 2	18 chunks	+245 lines, -680 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/462403004/diff/20001/runtime/vm/deopt_instructions.h File runtime/vm/deopt_instructions.h (right): https://codereview.chromium.org/462403004/diff/20001/runtime/vm/deopt_instructions.h#newcode323 runtime/vm/deopt_instructions.h:323: explicit GenericDeoptSource(intptr_t source_index) Is this constructor used at ...

6 years, 4 months ago (2014-08-22 17:05:45 UTC) #2

Vyacheslav Egorov (Google)

Thanks for the review. I will add more comments around SourceReader (which is rather a ...

6 years, 4 months ago (2014-08-23 00:26:45 UTC) #4

Vyacheslav Egorov (Google)

6 years, 4 months ago (2014-08-25 15:11:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as 39519 (presubmit successful).

Expand Messages | Collapse Messages