pkg/logging: added stackTrace support

pkg/logging: added stackTrace support

Plus:

* don't expose mutable children collection from Logger
* remove superfluous field
* other tweaks

BUG=https://code.google.com/p/dart/issues/detail?id=14416
R=sethladd@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29324

[sethladd, 2013-10-25 23:44:56]

thanks, lgtm. where are the tests for this package? do they require updating?

https://codereview.chromium.org/46233002/diff/60001/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/46233002/diff/60001/pkg/logging/lib/logging.d...
pkg/logging/lib/logging.dart:167: void finest(String message, [Object exception,
StackTrace stackTrace]) =>
should all these exceptions be errors. I get the sense that the term exception
is downplayed as more things are labeled simply as errors.

[kevmoo-old, 2013-10-25 23:54:01]

https://codereview.chromium.org/46233002/diff/60001/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/46233002/diff/60001/pkg/logging/lib/logging.d...
pkg/logging/lib/logging.dart:167: void finest(String message, [Object exception,
StackTrace stackTrace]) =>
On 2013/10/25 23:44:56, sethladd wrote:
> should all these exceptions be errors. I get the sense that the term exception
> is downplayed as more things are labeled simply as errors.

Done.

[sethladd, 2013-10-25 23:55:44]

lgtm thanks, but where are the tests? :)

[Siggi Cherem (dart-lang), 2013-10-26 00:08:33]

lgtm

[kevmoo-old, 2013-10-27 17:38:55]

Committed patchset #6 manually as r29324 (presubmit successful).