Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 462253005: Initial cut at having the enum objects from the spec generated as classes with public static string… (Closed)

Created:
6 years, 4 months ago by jwren
Modified:
6 years, 4 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org, ricow1, Brian Wilkerson
Visibility:
Public.

Description

Initial cut at having the enum objects from the spec generated as classes with public static strings. Type/enum aren't being generated yet. R=paulberry@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39240

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : whitespace nit #

Total comments: 2

Patch Set 4 : rebase with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -225 lines) Patch
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisService.java View 1 chunk +22 lines, -13 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionRelevance.java View 1 chunk +15 lines, -12 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestionKind.java View 1 chunk +63 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/DebugService.java View 1 chunk +12 lines, -8 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ElementKind.java View 1 chunk +59 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorSeverity.java View 1 chunk +15 lines, -12 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorType.java View 1 chunk +37 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExecutableKind.java View 1 chunk +14 lines, -15 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FoldingKind.java View 1 chunk +35 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HighlightRegionType.java View 1 chunk +95 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditSuggestionKind.java View 1 chunk +16 lines, -23 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringKind.java View 1 chunk +17 lines, -5 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringProblemSeverity.java View 1 chunk +16 lines, -15 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java View 1 chunk +37 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ServerService.java View 1 chunk +12 lines, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 2 3 chunks +142 lines, -110 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jwren
6 years, 4 months ago (2014-08-13 22:58:27 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/462253005/diff/40001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java (right): https://codereview.chromium.org/462253005/diff/40001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java#newcode26 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java:26: public static final String DECLARATION = "DECLARATION"; We're ...
6 years, 4 months ago (2014-08-13 23:53:24 UTC) #2
scheglov
LGTM
6 years, 4 months ago (2014-08-14 02:39:10 UTC) #3
jwren
https://codereview.chromium.org/462253005/diff/40001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java (right): https://codereview.chromium.org/462253005/diff/40001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java#newcode26 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java:26: public static final String DECLARATION = "DECLARATION"; Agreed! At ...
6 years, 4 months ago (2014-08-14 05:21:50 UTC) #4
jwren
6 years, 4 months ago (2014-08-14 05:23:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as 39240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698