Issue 46173002: - Make sure to keep the main/control port opened until the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46173002: - Make sure to keep the main/control port opened until the (Closed)

Created:
7 years, 1 month ago by Ivan Posva

Modified:
7 years, 1 month ago

Reviewers:
Cutch, siva, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Make sure to keep the main/control port opened until the isolate is finished. - Account for the number of opened control ports to be able to determine whether there are live ports. - Fix imports in snapshotted test. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29315

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -17 lines)			Patch
M	runtime/lib/isolate.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	4 chunks	+17 lines, -9 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/message_handler.h	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	tests/standalone/issue14236_source.dart	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Eventually I would like for the main invocation also to go through an initial message. ...

7 years, 1 month ago (2013-10-25 23:32:12 UTC) #1

Ivan Posva

Committed patchset #1 manually as r29315 (presubmit successful).

7 years, 1 month ago (2013-10-26 20:50:27 UTC) #4

floitsch

7 years, 1 month ago (2013-10-28 22:44:56 UTC) #5

Message was sent while issue was closed.

lgtm.

https://codereview.chromium.org/46173002/diff/1/tests/standalone/issue14236_s...
File tests/standalone/issue14236_source.dart (right):

https://codereview.chromium.org/46173002/diff/1/tests/standalone/issue14236_s...
tests/standalone/issue14236_source.dart:14: import
"package:async_helper/async_helper.dart";
argh. sorry about that.

Expand Messages | Collapse Messages