Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 46163009: Return an absolute URI for Platform.script. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix apidoc, add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M sdk/lib/io/platform.dart View 1 1 chunk +12 lines, -4 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/print_env.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/process_environment_test.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-11-01 10:09:39 UTC) #1
Anders Johnsen
lgtm https://codereview.chromium.org/46163009/diff/1/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/46163009/diff/1/sdk/lib/io/platform.dart#newcode84 sdk/lib/io/platform.dart:84: * isolate. If the script argument on the ...
7 years, 1 month ago (2013-11-01 10:13:50 UTC) #2
Anders Johnsen
One more comment, can you add a test to check it's absolute, when being spawned ...
7 years, 1 month ago (2013-11-01 10:14:44 UTC) #3
Søren Gjesse
lgtm https://codereview.chromium.org/46163009/diff/1/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/46163009/diff/1/sdk/lib/io/platform.dart#newcode88 sdk/lib/io/platform.dart:88: * This implies that a path including "link/.." ...
7 years, 1 month ago (2013-11-01 10:17:28 UTC) #4
Bill Hesse
Committed patchset #1 manually as r29740.
7 years, 1 month ago (2013-11-01 10:37:42 UTC) #5
Bill Hesse
Comments addressed, test added, apidoc fixed on Windows. https://codereview.chromium.org/46163009/diff/1/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/46163009/diff/1/sdk/lib/io/platform.dart#newcode84 sdk/lib/io/platform.dart:84: * ...
7 years, 1 month ago (2013-11-01 12:49:45 UTC) #6
Anders Johnsen
lgtm
7 years, 1 month ago (2013-11-01 12:51:42 UTC) #7
Søren Gjesse
lgtm
7 years, 1 month ago (2013-11-01 12:53:12 UTC) #8
Bill Hesse
7 years, 1 month ago (2013-11-04 07:26:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r29792 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698