Issue 461283002: Improve spec style and minor changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 461283002: Improve spec style and minor changes (Closed)

Created:
6 years, 4 months ago by Brian Wilkerson

Modified:
6 years, 4 months ago

Reviewers:
Paul Berry, jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -108 lines)			Patch
M	pkg/analysis_server/doc/api.html	View	11 chunks	+46 lines, -49 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	3 chunks	+2 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	3 chunks	+16 lines, -44 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/to_html.dart	View	4 chunks	+32 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

The analysis server tests passed. Is there something else I should test before committing this ...

6 years, 4 months ago (2014-08-13 00:29:24 UTC) #1

Paul Berry

lgtm. I believe running analysis server tests should be sufficient. Note that normally you would ...

6 years, 4 months ago (2014-08-13 03:07:54 UTC) #2

Brian Wilkerson

6 years, 4 months ago (2014-08-13 14:47:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39199 (presubmit successful).