Issue 460973002: Add dummy implementation of defaultResponseHeaders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460973002: Add dummy implementation of defaultResponseHeaders (Closed)

Created:
6 years, 4 months ago by Søren Gjesse

Modified:
6 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add dummy implementation of defaultResponseHeaders This fixes the analyzer redness on the buildbot. TBR=nweiz@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39122

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	pkg/http_multi_server/lib/http_multi_server.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as 39122 (presubmit successful).

6 years, 4 months ago (2014-08-12 09:54:29 UTC) #1

Søren Gjesse

This only fixed the bot redness, does not implement default response headers for multi_http_server.

6 years, 4 months ago (2014-08-12 12:05:00 UTC) #2

nweiz

6 years, 4 months ago (2014-08-13 00:15:03 UTC) #3

Message was sent while issue was closed.

On 2014/08/12 12:05:00, Søren Gjesse wrote:
> This only fixed the bot redness, does not implement default response headers
for
> multi_http_server.

lgtm

In the future, please follow the package versioning guidelines:
https://docs.google.com/a/google.com/document/d/1kPhEF8rL53S45SpzboyddKW61EUn....
In this case, the version should have been updated to 1.1.0-dev.

Expand Messages | Collapse Messages