Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 46063010: Change dart:io Platform.script to return a Uri. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1, ahe
Visibility:
Public.

Description

Change dart:io Platform.script to return a Uri. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29651

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -158 lines) Patch
M pkg/analyzer/lib/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/coverage_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/lib/docgen.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/http_server/test/utils.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/scheduled_test/test/metatest.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/test/support.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/sample_extension/test/sample_extension_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/samples/darttags/darttags.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/samples/jsonify/jsonify.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/dartdoc/test/dartdoc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/platform.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/async_compiler_input_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/bad_loop_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/codegen_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/diagnose_ambiguous_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_source_file_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_tree_shaking_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/package_root_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_promotion_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/unneeded_part_js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_io_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/standalone/coverage_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/http_launch_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/code_collection_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_read_special_device_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_read_stdio_script.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_cross_process_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_close_response_after_error_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 8 chunks +15 lines, -12 lines 0 comments Download
M tests/standalone/io/https_bad_certificate_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/https_unauthorized_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/print_sync_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/process_check_arguments_script.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_set_exit_code_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/standalone/io/process_shell_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_sync_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_server_socket_argument_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_socket_cross_process_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/regress_7191_script.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/regress_7191_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/resolve_symbolic_links_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_bad_certificate_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_builtin_roots_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_client_raw_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_server_client_no_certificate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_socket_bad_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_unauthorized_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_cross_process_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_extension_fail_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_extension_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/web_socket_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/windows_environment_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/standalone/typed_data_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/docs/bin/docs.dart View 1 chunk +4 lines, -13 lines 0 comments Download
M tools/dom/docs/test/docs_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/compiler/create_snapshot.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
This change was committed as r29619 and r29624, and the buildbot was green. It is ...
7 years, 1 month ago (2013-10-31 02:27:30 UTC) #1
Søren Gjesse
LGTM
7 years, 1 month ago (2013-10-31 07:08:53 UTC) #2
Søren Gjesse
7 years, 1 month ago (2013-10-31 07:29:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698