Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 460523002: Even easier observatory testing. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Even easier observatory testing. Tester/testee code in single file. Less boilerplate: shared setup and future chaining. Also supports concurrent testee (see gc_test). Simplify all exisiting tests to use new style. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39151

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -169 lines) Patch
D runtime/bin/vmservice/observatory/test/allocations_script.dart View 1 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/allocations_test.dart View 1 2 3 1 chunk +23 lines, -21 lines 0 comments Download
D runtime/bin/vmservice/observatory/test/gc_script.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/gc_test.dart View 1 1 chunk +29 lines, -29 lines 0 comments Download
D runtime/bin/vmservice/observatory/test/metrics_script.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/metrics_test.dart View 1 1 chunk +34 lines, -39 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/test_helper.dart View 1 2 3 chunks +46 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 4 months ago (2014-08-11 15:12:29 UTC) #1
Cutch
lgtm w/c https://codereview.chromium.org/460523002/diff/40001/runtime/bin/vmservice/observatory/test/allocations_test.dart File runtime/bin/vmservice/observatory/test/allocations_test.dart (right): https://codereview.chromium.org/460523002/diff/40001/runtime/bin/vmservice/observatory/test/allocations_test.dart#newcode24 runtime/bin/vmservice/observatory/test/allocations_test.dart:24: return lib.classes.first.load().then((Class fooClass) { Will 'Foo' always ...
6 years, 4 months ago (2014-08-12 14:33:07 UTC) #2
koda
https://codereview.chromium.org/460523002/diff/40001/runtime/bin/vmservice/observatory/test/allocations_test.dart File runtime/bin/vmservice/observatory/test/allocations_test.dart (right): https://codereview.chromium.org/460523002/diff/40001/runtime/bin/vmservice/observatory/test/allocations_test.dart#newcode24 runtime/bin/vmservice/observatory/test/allocations_test.dart:24: return lib.classes.first.load().then((Class fooClass) { On 2014/08/12 14:33:07, Cutch wrote: ...
6 years, 4 months ago (2014-08-12 16:53:08 UTC) #3
koda
6 years, 4 months ago (2014-08-12 17:55:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r39151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698