Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 460423003: Get the RemoteAnalysisServer to compile against the new generated AnalysisServer interface. (Closed)

Created:
6 years, 4 months ago by jwren
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, ricow1, Paul Berry
Visibility:
Public.

Description

Get the RemoteAnalysisServer to compile against the new generated AnalysisServer interface. This disables any and all functionality that is not up to date with the current server spec. R=brianwilkerson@google.com, paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=39164

Patch Set 1 #

Patch Set 2 : rebase with bleeding_edge #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1781 lines, -2308 lines) Patch
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisErrorsConsumer.java View 1 chunk +0 lines, -30 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 3 chunks +287 lines, -228 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer2.java View 1 2 1 chunk +0 lines, -394 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AssistsConsumer.java View 1 chunk +0 lines, -29 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/CompletionIdConsumer.java View 1 chunk +0 lines, -29 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/CreateContextConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/DebugCreateContextConsumer.java View 1 chunk +0 lines, -30 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindMemberDeclarationsConsumer.java View 1 chunk +3 lines, -8 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindMemberReferencesConsumer.java View 1 chunk +3 lines, -8 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindTopLevelDeclarationsConsumer.java View 1 chunk +4 lines, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FixesConsumer.java View 1 chunk +0 lines, -30 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetAssistsConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetAvailableRefactoringsConsumer.java View 1 chunk +4 lines, -8 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetErrorsConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetFixesConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetHoverConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetRefactoringConsumer.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetSuggestionsConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetTypeHierarchyConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetVersionConsumer.java View 1 chunk +1 line, -1 line 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/HoverConsumer.java View 1 chunk +0 lines, -30 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/TypeHierarchyConsumer.java View 1 chunk +0 lines, -30 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/VersionConsumer.java View 1 chunk +0 lines, -29 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 7 chunks +231 lines, -168 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AssistsProcessor.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/CompletionIdProcessor.java View 1 chunk +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FixesProcessor.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/TypeHierarchyProcessor.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/VersionProcessor.java View 1 chunk +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 chunk +31 lines, -45 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/AbstractServerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/integration/AbstractServerIntegrationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 24 chunks +1040 lines, -1050 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/DartProjectManager.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/DartProjectManagerTest.java View 2 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/TopLevelElementProvider_NEW.java View 2 chunks +21 lines, -24 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindDeclarationsAction_NEW.java View 3 chunks +17 lines, -20 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java View 4 chunks +38 lines, -40 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartCompletionProcessor.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartPriorityFilesHelper_NEW.java View 3 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartReconcilingStrategy.java View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartHover.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/typehierarchy/TypeHierarchyContentProvider_NEW.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartPriorityFilesHelper_NEW_Test.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 4 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jwren
6 years, 4 months ago (2014-08-12 20:44:05 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-12 20:55:05 UTC) #2
Paul Berry
lgtm
6 years, 4 months ago (2014-08-12 20:57:08 UTC) #3
jwren
6 years, 4 months ago (2014-08-12 21:14:49 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as 39164 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698