Issue 45993002: Remove now-prohibited default values from optional parameters of redirecting constructors in mirror…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45993002: Remove now-prohibited default values from optional parameters of redirecting constructors in mirror… (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove now-prohibited default values from optional parameters of redirecting constructors in mirror tests. BUG=http://dartbug.com/14285 BUG=http://dartbug.com/14472 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=29300

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
		tests/lib/lib.status	View		3 chunks	+0 lines, -5 lines	2 comments	Download
		tests/lib/mirrors/redirecting_factory_test.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://codereview.chromium.org/45993002/diff/170001/tests/lib/lib.status File tests/lib/lib.status (left): https://codereview.chromium.org/45993002/diff/170001/tests/lib/lib.status#oldcode171 tests/lib/lib.status:171: [ $runtime == vm ] This doesn't include Dartium, ...

7 years, 1 month ago (2013-10-25 23:11:58 UTC) #1

regis

LGTM https://codereview.chromium.org/45993002/diff/170001/tests/lib/lib.status File tests/lib/lib.status (left): https://codereview.chromium.org/45993002/diff/170001/tests/lib/lib.status#oldcode171 tests/lib/lib.status:171: [ $runtime == vm ] On 2013/10/25 23:11:59, ...

7 years, 1 month ago (2013-10-25 23:21:01 UTC) #2

rmacnak

7 years, 1 month ago (2013-10-25 23:21:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29300 (presubmit successful).

Expand Messages | Collapse Messages