dart2dart: Fix a scoping bug in the translation of loops.

dart2dart: Fix a scoping bug in the translation of loops.

Side effects to local variables in the condition must be visible after
the loop exit.  Thus the translation of the statements following a
loop must be in the scope of the condition.

R=sigurdm@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39121

[sigurdm, 2014-08-12 07:25:53]

lgtm

https://codereview.chromium.org/459763003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart
(right):

https://codereview.chromium.org/459763003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:687: // let
cont loop(x, ...) =
Should this be loop(v, ...)?

[sigurdm, 2014-08-12 07:26:37]

https://codereview.chromium.org/459763003/diff/1/tests/language/for_test.dart
File tests/language/for_test.dart (right):

https://codereview.chromium.org/459763003/diff/1/tests/language/for_test.dart...
tests/language/for_test.dart:49: static int f6() {
Maybe a comment explaining what we are testing?

[Kevin Millikin (Google), 2014-08-12 08:54:56]

https://codereview.chromium.org/459763003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart
(right):

https://codereview.chromium.org/459763003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:687: // let
cont loop(x, ...) =
On 2014/08/12 07:25:53, sigurdm wrote:
> Should this be loop(v, ...)?

It's not necessarily the same as the v, ... passed to loop or continue (those
aren't necessarily the same as each other, either, to be precise).  I'm trying
to use x to range over parameters, p (or sometimes a real name like cond) to
range over let-prim bound primitives, and v to range over all primitives.

But I'm probably not consistent :)

https://codereview.chromium.org/459763003/diff/1/tests/language/for_test.dart
File tests/language/for_test.dart (right):

https://codereview.chromium.org/459763003/diff/1/tests/language/for_test.dart...
tests/language/for_test.dart:49: static int f6() {
On 2014/08/12 07:26:37, sigurdm wrote:
> Maybe a comment explaining what we are testing?

Good idea, done.

[Kevin Millikin (Google), 2014-08-12 08:55:23]

Committed patchset #2 manually as 39121 (presubmit successful).