Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 459703002: New analyzer snapshot. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

New analyzer snapshot. Basically it includes all the code that was not translated before. Includes new library: element_handle, but it should not be used because of WeakReference absence in Dart. Includes new test: engine_test, but it has too much code requirering manual tweaks, after we will stop translating. All other tests are in all_the_rest.dart, again to be moved into corresponding libraries and cleaned up later. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22395 lines, -113 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 3 chunks +12 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/handle/ElementHandle.java View 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolver.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/NonExistingSource.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/Source.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/SourceFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java View 3 chunks +8 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/task/ParseHtmlTaskTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/source/FileBasedSourceTest.java View 10 chunks +10 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/source/NonExistingSourceTest.java View 1 chunk +1 line, -1 line 0 comments Download
A editor/util/plugins/com.google.dart.java2dart/resources/element_handle_include.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine_io.dart View 1 chunk +3 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_junit.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/test_support_include.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 2 chunks +12 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 2 chunks +5 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineExceptionProcessor.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 1 chunk +3 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 28 chunks +150 lines, -31 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/JUnitSemanticProcessor.java View 1 chunk +6 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 2 chunks +22 lines, -1 line 0 comments Download
M pkg/analyzer/bin/analyzer.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +998 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 15 chunks +51 lines, -46 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine_io.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_junit.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +10 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/test/generated/all_the_rest.dart View 1 chunk +13944 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/engine_test.dart View 1 chunk +7069 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-08-10 20:54:55 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-11 14:02:25 UTC) #2
scheglov
6 years, 4 months ago (2014-08-11 15:41:56 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as 39091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698