Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 459643002: Improve matchers for enums defined by the analysis server API. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve matchers for enums defined by the analysis server API. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -16 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 15 chunks +15 lines, -15 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-09 14:59:29 UTC) #1
jwren
On 2014/08/09 14:59:29, Paul Berry wrote: LGTM
6 years, 4 months ago (2014-08-10 14:22:13 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-11 15:21:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698