Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 458453003: Split up server_domain_int_test.dart; regularize integration test directories. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split up server_domain_int_test.dart; regularize integration test directories. With this change, there is a separate subfolder in "test/integration" for each domain, and each subfolder has its own "test_all.dart". This change is almost entirely code motion. The only material change is that two tests have been dropped: - test_connected(): this test is now unnecessary since every time the "server.connected" message is received, the generated code in integration_test_methods.dart verifies that it is well-formed. - test_error(): this was a placeholder to remind us to test the "server.error" notification. On further reflection, it's unlikely that we'll be able to integration test this notification, since it only occurs in the event of a server bug. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39112

Patch Set 1 #

Patch Set 2 : Update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -492 lines) Patch
A + pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
A + pkg/analysis_server/test/integration/completion/test_all.dart View 1 chunk +6 lines, -8 lines 0 comments Download
D pkg/analysis_server/test/integration/completion_domain_int_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
A + pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/test/integration/search/test_all.dart View 1 chunk +4 lines, -7 lines 0 comments Download
D pkg/analysis_server/test/integration/search_domain_int_test.dart View 1 chunk +0 lines, -284 lines 0 comments Download
A + pkg/analysis_server/test/integration/server/get_version_test.dart View 1 chunk +7 lines, -4 lines 0 comments Download
A pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/server/set_subscriptions_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/server/shutdown_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/server/status_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/server/test_all.dart View 1 chunk +28 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/integration/server_domain_int_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/pkg.status View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-11 21:55:52 UTC) #1
jwren
On 2014/08/11 21:55:52, Paul Berry wrote: LGTM
6 years, 4 months ago (2014-08-11 22:22:42 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-11 22:25:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r39112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698