Issue 45833003: Fix directory-listing to return a future on cancel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45833003: Fix directory-listing to return a future on cancel. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix directory-listing to return a future on cancel. This also fixes an issue where we would leake FDs/HANDLEs if the listing was interrupted. Add new pause-resume-cancel test of directory listing. BUG=https://code.google.com/p/dart/issues/detail?id=10163 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29454

Patch Set 1 #

Patch Set 2 : Fix reporting of immediate errors from directory listing. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -31 lines)			Patch
M	runtime/bin/directory.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/bin/directory.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/directory_android.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	runtime/bin/directory_linux.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	runtime/bin/directory_macos.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	1	5 chunks	+19 lines, -10 lines	0 comments	Download
M	tests/standalone/io/directory_list_pause_test.dart	View		1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

7 years, 1 month ago (2013-10-29 15:05:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29454 (presubmit successful).

Expand Messages | Collapse Messages