Disallow explicit parameter default values in redirecting factory (issue 13662).

Disallow explicit parameter default values in redirecting factory (issue 13662).
Add language test.
Fix usage in core lib.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29298

[hausner, 2013-10-25 22:26:38]

LGTM with nit.

https://codereview.chromium.org/45833002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/45833002/diff/1/runtime/vm/parser.cc#newcode3031
runtime/vm/parser.cc:3031: ErrorMsg("redirecting factory '%s' may not specify a
default value "
Should this message use plural, like: may not specify default values for
optional parameters?

[regis, 2013-10-25 22:54:42]

Thanks!

I had to mark a few tests as failing for dart2js, dart2dart, and analyzer, as
well as disable a mirror test now breaking the law.
Issues were filed for all of the above.

https://codereview.chromium.org/45833002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/45833002/diff/1/runtime/vm/parser.cc#newcode3031
runtime/vm/parser.cc:3031: ErrorMsg("redirecting factory '%s' may not specify a
default value "
On 2013/10/25 22:26:38, hausner wrote:
> Should this message use plural, like: may not specify default values for
> optional parameters?

The spec uses singular, but I changed it to plural here.

[regis, 2013-10-25 23:02:55]

Committed patchset #2 manually as r29298 (presubmit successful).