Issue 45763004: Revert "Re-land "Search for main in the exported names of the main library, not in the library itse…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45763004: Revert "Re-land "Search for main in the exported names of the main library, not in the library itse… (Closed)

Created:
7 years, 1 month ago by kasperl

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Re-land "Search for main in the exported names of the main library, not in the library itself."" This reverts commit 2323a2ca0c702657021f0cb2b532402eafd13d49. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29810

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -79 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	4 chunks	+5 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/language/export_ambiguous_main_a.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	tests/language/export_ambiguous_main_b.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	tests/language/export_ambiguous_main_negative_test.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	tests/language/export_double_same_main_test.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	tests/language/export_main_override_test.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	tests/language/export_main_test.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

Committed patchset #1 manually as r29810 (presubmit successful).

7 years, 1 month ago (2013-11-04 15:28:05 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages