Issue 457403002: Revert revision 39082

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 457403002: Revert revision 39082 (Closed)

Created:
6 years, 4 months ago by ricow1

Modified:
6 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert revision 39082 This is causing a strange failure on browser bots, debugging offline Committed: https://code.google.com/p/dart/source/detail?r=39088

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/bots/compiler.py	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r39088 (presubmit successful).

6 years, 4 months ago (2014-08-11 13:43:05 UTC) #2

Bill Hesse

LGTM, but wouldn't it be better to remove the lines than move them?

6 years, 4 months ago (2014-08-11 13:59:29 UTC) #3

ricow1

6 years, 4 months ago (2014-08-12 06:07:19 UTC) #4

Message was sent while issue was closed.

On 2014/08/11 13:59:29, Bill Hesse wrote:
> LGTM, but wouldn't it be better to remove the lines than move them?

Not really, that would also disable this on non browser bots

Expand Messages | Collapse Messages