Refactor isolate startup code in preparation for making isolate spawning more truly non-blocking.

Refactor isolate startup code in preparation for making isolate spawning more truly non-blocking.

Instead of passing a startup message to the new isolate, pass all
necessary information in to _startIsolate directly.  The new isolate
sends its control port and capabilities back to the parent.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39423

[turnidge, 2014-08-19 20:17:08]

Uploaded some new diffs.  Ready for a look.

[Ivan Posva, 2014-08-19 23:21:31]

LGTMwC -ip

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:203: var readyMessage = [];
readyMessage = new List(2);

This does not have to be a growable list, correct?

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:239: readyPort.close();
readyPort = null;

So that we do not attempt to close it again below?

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:267: readyPort.close();
ditto.

https://codereview.chromium.org/456983002/diff/40001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/456983002/diff/40001/runtime/vm/isolate.h#new...
runtime/vm/isolate.h:806: explicit IsolateSpawnState(Dart_Port parent_port,
No need for explicit any longer.

https://codereview.chromium.org/456983002/diff/40001/runtime/vm/isolate.h#new...
runtime/vm/isolate.h:809: explicit IsolateSpawnState(Dart_Port parent_port,
ditto.

[turnidge, 2014-08-20 19:56:27]

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:203: var readyMessage = [];
On 2014/08/19 23:21:31, Ivan Posva wrote:
> readyMessage = new List(2);
> 
> This does not have to be a growable list, correct?

Done.

https://codereview.chromium.org/456983002/diff/40001/runtime/lib/isolate_patc...
runtime/lib/isolate_patch.dart:239: readyPort.close();
On 2014/08/19 23:21:31, Ivan Posva wrote:
> readyPort = null;
> 
> So that we do not attempt to close it again below?

Not needed because closure isn't covered by the catch.

https://codereview.chromium.org/456983002/diff/40001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/456983002/diff/40001/runtime/vm/isolate.h#new...
runtime/vm/isolate.h:806: explicit IsolateSpawnState(Dart_Port parent_port,
On 2014/08/19 23:21:31, Ivan Posva wrote:
> No need for explicit any longer.

Done.

https://codereview.chromium.org/456983002/diff/40001/runtime/vm/isolate.h#new...
runtime/vm/isolate.h:809: explicit IsolateSpawnState(Dart_Port parent_port,
On 2014/08/19 23:21:31, Ivan Posva wrote:
> ditto.

Done.

[turnidge, 2014-08-20 19:57:19]

Committed patchset #4 manually as 39423 (presubmit successful).