Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 456893002: Support for excluded files/folders. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -61 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 8 chunks +131 lines, -36 lines 2 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 3 chunks +139 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 5 chunks +36 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 8 chunks +35 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-08 18:55:21 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/456893002/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/456893002/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode157 pkg/analysis_server/lib/src/context_manager.dart:157: ChangeSet changeSet = new ChangeSet(); Can we merge ...
6 years, 4 months ago (2014-08-08 19:19:35 UTC) #2
Paul Berry
lgtm
6 years, 4 months ago (2014-08-08 19:37:53 UTC) #3
scheglov
6 years, 4 months ago (2014-08-08 19:42:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698