Integration test search.getTypeHierarchy and make some minor fixes.

Integration test search.getTypeHierarchy and make some minor fixes.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39045

[scheglov, 2014-08-08 18:40:33]

https://codereview.chromium.org/456613004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/search/search_domain.dart (right):

https://codereview.chromium.org/456613004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/search/search_domain.dart:142:
response.setEmptyResult();
I don't understand why we do this.
The field should be absent, and it is null by default, right?

https://codereview.chromium.org/456613004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/search/search_domain.dart:152:
response.setEmptyResult();
Same here.

[Brian Wilkerson, 2014-08-08 18:47:31]

LGTM

[Paul Berry, 2014-08-08 19:23:04]

https://codereview.chromium.org/456613004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/search/search_domain.dart (right):

https://codereview.chromium.org/456613004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/search/search_domain.dart:142:
response.setEmptyResult();
On 2014/08/08 18:40:33, scheglov wrote:
> I don't understand why we do this.
> The field should be absent, and it is null by default, right?

Without this call the response message would be

  {"id": ...}

But it the spec defines the response format as:

  response: {
    "id": String
    "error": optional Error
    "result": {
      "hierarchyItems": optional List<TypeHierarchyItem>
    }
  }

which implies that the response should be:

  {"id": ..., "result": {}}

The call to setEmptyResult() ensures that "result": {} is present.

[scheglov, 2014-08-08 19:28:30]

LGTM

[Paul Berry, 2014-08-08 19:39:57]

Committed patchset #1 manually as r39045 (presubmit successful).