Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 455983002: Rework search_domain_int_test to avoid timeouts. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rework search_domain_int_test to avoid timeouts. Now all sub-tests are run using a single analysis server so that the SDK only needs to be analyzed once. Reduces test time by about 9x. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M pkg/analysis_server/test/integration/search_domain_int_test.dart View 10 chunks +40 lines, -15 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-08 21:46:52 UTC) #1
scheglov
lgtm
6 years, 4 months ago (2014-08-08 22:03:58 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-09 14:19:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698