Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 45583003: Handle long relative path dependencies better. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom
Modified:
7 years, 1 month ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle long relative path dependencies better. BUG=https://code.google.com/p/dart/issues/detail?id=14442 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=29613

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revise. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -17 lines) Patch
M sdk/lib/_internal/pub/lib/src/source/path.dart View 1 3 chunks +16 lines, -17 lines 0 comments Download
A sdk/lib/_internal/pub/test/build/handles_long_paths_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
7 years, 1 month ago (2013-10-30 23:33:31 UTC) #1
nweiz
lgtm https://codereview.chromium.org/45583003/diff/1/sdk/lib/_internal/pub/lib/src/source/path.dart File sdk/lib/_internal/pub/lib/src/source/path.dart (right): https://codereview.chromium.org/45583003/diff/1/sdk/lib/_internal/pub/lib/src/source/path.dart#newcode44 sdk/lib/_internal/pub/lib/src/source/path.dart:44: return true; [createPackageSymlink] shouldn't be in the try/catch ...
7 years, 1 month ago (2013-10-31 00:29:08 UTC) #2
Bob Nystrom
Thanks! https://codereview.chromium.org/45583003/diff/1/sdk/lib/_internal/pub/lib/src/source/path.dart File sdk/lib/_internal/pub/lib/src/source/path.dart (right): https://codereview.chromium.org/45583003/diff/1/sdk/lib/_internal/pub/lib/src/source/path.dart#newcode44 sdk/lib/_internal/pub/lib/src/source/path.dart:44: return true; On 2013/10/31 00:29:08, nweiz wrote: > ...
7 years, 1 month ago (2013-10-31 00:31:11 UTC) #3
Bob Nystrom
7 years, 1 month ago (2013-10-31 00:31:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698