Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 455693002: Add package links for the observatory and enable testing (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add package links for the observatory and enable testing This will make them run on the vm bots, not the pkg bots (I can move them if need be by changing the exclude filter, but I assume you want full vm coverage for this? ) Committed: https://code.google.com/p/dart/source/detail?r=39021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/pkg.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/vmservice.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 4 months ago (2014-08-08 07:46:14 UTC) #1
ricow1
TBR to make sure everything is working before I leave
6 years, 4 months ago (2014-08-08 07:47:35 UTC) #2
ricow1
Committed patchset #1 manually as r39021 (presubmit successful).
6 years, 4 months ago (2014-08-08 07:47:49 UTC) #3
koda
6 years, 4 months ago (2014-08-08 14:09:20 UTC) #4
Message was sent while issue was closed.
lgtm
yes, I think this setup is preferable. thanks

Powered by Google App Engine
This is Rietveld 408576698