Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 455673003: Don't run observatory tests on the browser, they are using dart:io (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't run observatory tests on the browser, they are using dart:io Committed: https://code.google.com/p/dart/source/detail?r=39025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/bin/vmservice/vmservice.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 4 months ago (2014-08-08 08:44:32 UTC) #1
ricow1
tbr
6 years, 4 months ago (2014-08-08 08:44:57 UTC) #2
ricow1
Committed patchset #1 manually as r39025 (presubmit successful).
6 years, 4 months ago (2014-08-08 08:45:50 UTC) #3
koda
6 years, 4 months ago (2014-08-08 13:52:27 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698