Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 455483002: Make camelcasing use a regular expression for CSS properties. (Closed)

Created:
6 years, 4 months ago by Emily Fortuna
Modified:
6 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make camelcasing use a regular expression for CSS properties. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=39012

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -50 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -12 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +6 lines, -14 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 1 chunk +4 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 1 chunk +4 lines, -12 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
6 years, 4 months ago (2014-08-07 21:36:34 UTC) #1
sra1
lgtm... but does it make swarm smaller? https://codereview.chromium.org/455483002/diff/20001/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate (right): https://codereview.chromium.org/455483002/diff/20001/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate#newcode81 tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:81: new RegExp('-([a-z]+)', ...
6 years, 4 months ago (2014-08-07 21:46:38 UTC) #2
sra1
lgtm https://codereview.chromium.org/455483002/diff/20001/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate (right): https://codereview.chromium.org/455483002/diff/20001/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate#newcode78 tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:78: String _camelCase(String hyphenated) { static
6 years, 4 months ago (2014-08-07 22:16:20 UTC) #3
Emily Fortuna
6 years, 4 months ago (2014-08-07 23:00:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as 39012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698