local code completion suggestions

local code completion suggestions

BUG=
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39069

[scheglov, 2014-08-10 21:45:15]

LGTM

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/completion/local_computer.dart (right):

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:14: * A computer
for calculating class and top level variable
You probably want to update the comment.

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:74:
variables.variables.forEach((VariableDeclaration v) {
Could you use full words, not just single characters?

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:81: if (s.offset <
offset) {
Not quite so easy.

This code is valid and would be nice to propose "a" in "b = 2 + ^".

main() {
  int a = 1, b = 2 + a;
  print(a);
  print(b);
}

Maybe worth to add TODO.

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:84: l.label;
I don't think this statement is useful.

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/test/c...
File pkg/analysis_services/test/completion/local_computer_test.dart (right):

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/test/c...
pkg/analysis_services/test/completion/local_computer_test.dart:19: class
LocalComputerTest extends AbstractCompletionTest {
Do we want to add tests that local variables of sibling blocks are not
suggested?

{
  {
    int a;
  }
  ^
}

Here "a" is not visible and should not be suggested.

[danrubel, 2014-08-11 02:19:00]

Committed patchset #3 manually as 39069 (presubmit successful).

[danrubel, 2014-08-11 03:04:39]

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/completion/local_computer.dart (right):

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:14: * A computer
for calculating class and top level variable
On 2014/08/10 21:45:14, scheglov wrote:
> You probably want to update the comment.

Done.

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:74:
variables.variables.forEach((VariableDeclaration v) {
On 2014/08/10 21:45:14, scheglov wrote:
> Could you use full words, not just single characters?

Good point. I have cleaned several places in this file.

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:81: if (s.offset <
offset) {
On 2014/08/10 21:45:14, scheglov wrote:
> Not quite so easy.
> 
> This code is valid and would be nice to propose "a" in "b = 2 + ^".
> 
> main() {
>   int a = 1, b = 2 + a;
>   print(a);
>   print(b);
> }
> 
> Maybe worth to add TODO.

Good point. https://codereview.chromium.org/459743002/

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/completion/local_computer.dart:84: l.label;
On 2014/08/10 21:45:15, scheglov wrote:
> I don't think this statement is useful.

Removed and commented out following line as it is not yet supported.

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/test/c...
File pkg/analysis_services/test/completion/local_computer_test.dart (right):

https://codereview.chromium.org/454403003/diff/1/pkg/analysis_services/test/c...
pkg/analysis_services/test/completion/local_computer_test.dart:19: class
LocalComputerTest extends AbstractCompletionTest {
On 2014/08/10 21:45:15, scheglov wrote:
> Do we want to add tests that local variables of sibling blocks are not
> suggested?
> 
> {
>   {
>     int a;
>   }
>   ^
> }
> 
> Here "a" is not visible and should not be suggested.

Good point. https://codereview.chromium.org/459743002/