Issue 453943004: Port metrics test to new framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453943004: Port metrics test to new framework. (Closed)

Created:
6 years, 4 months ago by koda

Modified:
6 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Port metrics test to new framework. Also extend it to actually check the values, rather than just types. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39049

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -85 lines)			Patch
A	runtime/bin/vmservice/observatory/test/metrics_script.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/observatory/test/metrics_test.dart	View	1 chunk	+44 lines, -0 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1 chunk	+0 lines, -85 lines	0 comments	Download

Total messages: 4 (0 generated)

koda

On 2014/08/08 20:51:41, Cutch wrote: > lgtm! FYI, as follow-up, I'd like to: 1. Have ...

6 years, 4 months ago (2014-08-08 20:55:37 UTC) #3

koda

6 years, 4 months ago (2014-08-08 20:59:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r39049 (presubmit successful).